fix: ensure invalid state is correctly set on slotted pickers #7074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
approved these changes
Jan 30, 2025
|
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
web-padawan
added a commit
that referenced
this pull request
Jan 30, 2025
…#7077) Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Jan 30, 2025
…#7076) Co-authored-by: Serhii Kulykov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.7.0.alpha7 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7073
Due to the change in #6922, the component always sets
invalidproperty onisInvalid()on attach. While this makes sense in general, it turns out that callingsetInvalid(true)on the DateTimePicker does not update corresponding state on its slotted pickers and they end up sendinginvalid = falseto the client on initialisation.Note: I'm not sure if this needs an IT since the problem is that
isInvalid()returns wrong value and that's now covered with a unit test. Just to clarify, this problem can't be reproduced in the web component (withoutClientValidationUtillogic).Type of change