fix: ensure that invalid state is set from the server #6922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the `preventWebComponentFromModifyingInvalidState` method in
`ClientValidationUtil` class to always set the invalid state of the
component on the client to override any client side validation that may
happen before the `_shouldSetInvalid` is overriden.
That's the root cause of the linked issue where a `ComboBox` can stay
stuck on invalid state on the client when user calls `setValue("")` on
the initialization of the component instance.
Fixes #6881
sissbruecker
approved these changes
Dec 12, 2024
web-padawan
approved these changes
Dec 12, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
DiegoCardoso
added a commit
that referenced
this pull request
Dec 12, 2024
….5) (#6931) Co-authored-by: Diego Cardoso <[email protected]>
DiegoCardoso
added a commit
that referenced
this pull request
Dec 12, 2024
….6) (#6930) Co-authored-by: Diego Cardoso <[email protected]>
This was referenced Jan 30, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the
preventWebComponentFromModifyingInvalidStatemethod inClientValidationUtilclass to always set the invalid state of the component on the client to override any client-side validation that may happen before the_shouldSetInvalidis overridden.That's the root cause of the linked issue where a
ComboBoxcan stay stuck in the invalid state on the client when the user callssetValue("")on the initialization of the component instance.Fixes #6881
Type of change