-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for zIndex on PointOptions subclasses #562
Conversation
Merge with upstream
…e ZIndex of the Scatter, Line & Spline chart types.
sorry it was overlooked for a while, PlotOptions classes are generated so we should fix this in the generator which is not publicly available, will keep open until proper fix is added |
@echarlus after taking a bit deeper look at |
Hi,
sorry for the late reply.
It indeed makes sense to set it on the PlotOptions since I need to set it for the whole Series.
So your implementation makes sense and resolves my issue.
Thanks !
Charles-Edouard Ruault
Le 22 mars 2019 à 10:41, Guille <[email protected]> a écrit :
@echarlus <https://github.com/echarlus> after taking a bit deeper look at zIndex usage I noticed it only makes sense when plot options are set to a data series and not when added to a Configuration via addPlotOptions.
I think it would make more sense to add zIndex to AbstractSeries instead.
Would this cover your use case for zIndex? or is the some case I'm missing where it would be more convenient to have it in plot options?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#562 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHKXc7GBnlFZz-TouJt0M9q_Oo1SG-wKks5vZKVLgaJpZM4Z-f55>.
|
Ok, I will close this PR in favor of the implementation in #571 adding zIndex to series type instead of plot options |
This allows to get/set the Z Index value for Spline, Scatter & Line charts
This change is