Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for zIndex on PointOptions subclasses #562

Closed
wants to merge 4 commits into from
Closed

Support for zIndex on PointOptions subclasses #562

wants to merge 4 commits into from

Conversation

echarlus
Copy link

@echarlus echarlus commented Jan 14, 2019

This allows to get/set the Z Index value for Spline, Scatter & Line charts


This change is Reviewable

@alvarezguille
Copy link
Member

sorry it was overlooked for a while, PlotOptions classes are generated so we should fix this in the generator which is not publicly available, will keep open until proper fix is added

@alvarezguille
Copy link
Member

@echarlus after taking a bit deeper look at zIndex usage I noticed it only makes sense when plot options are set to a data series and not when added to a Configuration via addPlotOptions.
I think it would make more sense to add zIndex to AbstractSeries instead.
Would this cover your use case for zIndex? or is the some case I'm missing where it would be more convenient to have it in plot options?

alvarezguille added a commit that referenced this pull request Mar 22, 2019
zIndex was not added to PlotOptions as it only makes sense
when used in a Series and not when used in Configuration
Alternate implementation to #562
Fixes #565
Fixes #331
alvarezguille added a commit that referenced this pull request Mar 22, 2019
zIndex was not added to PlotOptions as it only makes sense
when used in a Series and not when used in Configuration
Alternate implementation to #562
Fixes #565
Fixes #331
@echarlus
Copy link
Author

echarlus commented Mar 22, 2019 via email

@alvarezguille
Copy link
Member

Ok, I will close this PR in favor of the implementation in #571 adding zIndex to series type instead of plot options

alvarezguille added a commit that referenced this pull request Mar 22, 2019
zIndex was not added to PlotOptions as it only makes sense
when used in a Series and not when used in Configuration
Alternate implementation to #562
Fixes #565
Fixes #331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants