Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highchart Global options cannot be set #508

Closed
echarlus opened this issue Mar 27, 2018 · 0 comments
Closed

Highchart Global options cannot be set #508

echarlus opened this issue Mar 27, 2018 · 0 comments

Comments

@echarlus
Copy link

The HighChart global options are represented by the class com.vaadin.addon.charts.model.Global but there is no way to attach it to com.vaadin.addon.charts.ChartOptions for it to be sent to the client.
Therefore one cannot set HighChart global options like useUTC etc.
@johannesh2 johannesh2 added this to the 4.1 milestone Mar 27, 2018
alvarezguille added a commit that referenced this issue Mar 28, 2018
@alvarezguille
Allow setting global options
1162292 
Fixes #508
Fixes #472
alvarezguille pushed a commit that referenced this issue Mar 28, 2018
@echarlus @alvarezguille
Allow setting Global options (#509)
b0376a8 
* Fix for Issue #508 : Highchart Global options cannot be set

* Add test for ChartOptions with global set
@alvarezguille alvarezguille mentioned this issue Mar 28, 2018
Merged
alvarezguille added a commit that referenced this issue Mar 28, 2018
@alvarezguille
Allow setting global options (#510)
7b13bd4 
Changes picked from #509
Fixes #508
Fixes #472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johannesh2 @echarlus