Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue #508 : Highchart Global options cannot be set #509

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Fix for Issue #508 : Highchart Global options cannot be set #509

merged 2 commits into from
Mar 28, 2018

Conversation

echarlus
Copy link

@echarlus echarlus commented Mar 27, 2018 •
edited by Artur-
Loading

These changes will add HighChart Global configuration to ChartOptions and allow it to be serialized and pushed back to the client.

This change is Reviewable

@alvarezguille
Copy link
Member

Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@alvarezguille alvarezguille merged commit b0376a8 into vaadin:4.0 Mar 28, 2018
@alvarezguille alvarezguille mentioned this pull request Mar 28, 2018
Merged
alvarezguille added a commit that referenced this pull request Mar 28, 2018
@alvarezguille
Allow setting global options (#510)
7b13bd4 
Changes picked from #509
Fixes #508
Fixes #472
@alvarezguille
Copy link
Member

Added a simple test and merged, thanks @echarlus !

@echarlus
Copy link
Author

@alvarezguille thanks for the reactivity !
Do you have any plans to release a 4.0.4 with the latest changes soon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echarlus @alvarezguille