Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved collection of category-acg #2249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved collection of category-acg #2249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion data/category-acg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,30 @@
include:abema
include:acfun @cn
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. a category-acg-cn would be better
  2. corp. like acfun may also have some sites mainly serving the oversea users. Labelling a sub-category does not practically make sense, see the point 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then how about have it split to category-acg-cn and category-acg-!cn?

include:anime
include:bahamut
include:bilibili @cn
include:dlsite
include:dmzj @cn
include:manhuagui
include:mfuns @cn
include:miaopai @cn
include:niconico
include:pixiv
include:sfacg @cn
include:volmoe

# Game
colorfulstage.com
include:bluearchive
include:cygames
include:illusion
include:kurogames @cn
include:lowiro
include:mihoyo
include:nexon
include:nikke
include:projectsekai
include:purikonejp
include:seasun @cn

# Idol
crypton.co.jp
Expand Down
3 changes: 0 additions & 3 deletions data/geolocation-!cn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
# This list contains domains that don't have access point in China mainland. This is opposite to geolocation-cn.

# Anime, Comics & Games
include:category-acg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a good idea.
You deleted domains from the collection geolocation-!cn for no good reasons.


# Advertisment & Analytics
include:pubmatic
include:taboola
Expand Down
Loading