Improved collection of category-acg #2249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xkww3n
force-pushed
the
update-category-acg
branch
from
1d5a653 to
db09b9d
Compare
|
Actually, I think this PR does not have any sense. Do you have any opinion? |
Previously this file contains almost nothing, this PR adds some ACG-related companies, games, etc. to it to make it fits to its name. |
IceCodeNew
requested changes
Jul 26, 2024
| @@ -1,5 +1,30 @@ | |||
| include:abema | |||
| include:acfun @cn | |||
There was a problem hiding this comment.
- a category-acg-cn would be better
- corp. like acfun may also have some sites mainly serving the oversea users. Labelling a sub-category does not practically make sense, see the point 1
There was a problem hiding this comment.
Then how about have it split to category-acg-cn and category-acg-!cn?
| @@ -1,8 +1,5 @@ | |||
| # This list contains domains that don't have access point in China mainland. This is opposite to geolocation-cn. | |||
|
|
|||
| # Anime, Comics & Games | |||
| include:category-acg | |||
There was a problem hiding this comment.
Not a good idea.
You deleted domains from the collection geolocation-!cn for no good reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.