Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake to use mbed_create_distro and latest mbed release #404

Open
wmmc88 opened this issue Jan 7, 2022 · 5 comments
Open

Update cmake to use mbed_create_distro and latest mbed release #404

wmmc88 opened this issue Jan 7, 2022 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@wmmc88
Copy link
Member

wmmc88 commented Jan 7, 2022

This repo currently uses a fork of mbed feauture branch feature-cmake-object-libraries that was patched by me to pull in a fix for STM32 targets(which has since been officially released upstream), and then patched by @cindyli-13 to provide several can fixes(I don't think these fixes were merged upstream but @cindyli-13 can confirm).

According to discussion in ARMmbed/mbed-os#13981, it seems like upstream mbed has gone a different direction and it looks like the feature-cmake-object-libraries is not going to be merged into mainline. Instead, it looks like mainline will be using the mbed_create_distro feature that merged in ARMmbed/mbed-os#15126 instead.

We should probably pull in the latest official upstream release (patched with our can fixes), and port our repo to use mbed_create_distro. As it stands, our fw repo is using a version of mbed thats missing ~a years worth of bugfixes, features, etc

@wmmc88 wmmc88 added the help wanted Extra attention is needed label Jan 7, 2022
@0xc0170
Copy link

0xc0170 commented Jan 10, 2022

According to discussion in ARMmbed/mbed-os#13981, it seems like upstream mbed has gone a different direction and it looks like the feature-cmake-object-libraries is not going to be merged into mainline. Instead, it looks like mainline will be using the mbed_create_distro feature that merged in ARMmbed/mbed-os#15126 instead.

It would be the best to use mbed_create_distro. The feature branch is already way behind and it won't be integrated anytime soon. Did the feature branch work for you? i wonder how much effort it is to update to the latest release and use this create distro function instead.

@wmmc88
Copy link
Member Author

wmmc88 commented Jan 10, 2022

According to discussion in ARMmbed/mbed-os#13981, it seems like upstream mbed has gone a different direction and it looks like the feature-cmake-object-libraries is not going to be merged into mainline. Instead, it looks like mainline will be using the mbed_create_distro feature that merged in ARMmbed/mbed-os#15126 instead.

It would be the best to use mbed_create_distro. The feature branch is already way behind and it won't be integrated anytime soon. Did the feature branch work for you? i wonder how much effort it is to update to the latest release and use this create distro function instead.

The feature branch did work for us and I found it fairly painless to migrate to that feature branch ~9 months ago.

Not sure how much work it will be for us to go from the feature branch to using mbed_create_distro as I haven't looked too much into it, but its a low priority for us at the moment and probably won't be addressed for a while.

@cindyli-13
Copy link
Member

cindyli-13 commented Jan 14, 2022

This repo currently uses a fork of mbed feauture branch feature-cmake-object-libraries that was patched by me to pull in a fix for STM32 targets(which has since been officially released upstream), and then patched by @cindyli-13 to provide several can fixes(I don't think these fixes were merged upstream but @cindyli-13 can confirm).

According to discussion in ARMmbed/mbed-os#13981, it seems like upstream mbed has gone a different direction and it looks like the feature-cmake-object-libraries is not going to be merged into mainline. Instead, it looks like mainline will be using the mbed_create_distro feature that merged in ARMmbed/mbed-os#15126 instead.

We should probably pull in the latest official upstream release (patched with our can fixes), and port our repo to use mbed_create_distro. As it stands, our fw repo is using a version of mbed thats missing ~a years worth of bugfixes, features, etc

The CAN patch was merged upstream actually in ARMmbed/mbed-os#14612

@wmmc88
Copy link
Member Author

wmmc88 commented Jan 15, 2022

This repo currently uses a fork of mbed feauture branch feature-cmake-object-libraries that was patched by me to pull in a fix for STM32 targets(which has since been officially released upstream), and then patched by @cindyli-13 to provide several can fixes(I don't think these fixes were merged upstream but @cindyli-13 can confirm).
According to discussion in ARMmbed/mbed-os#13981, it seems like upstream mbed has gone a different direction and it looks like the feature-cmake-object-libraries is not going to be merged into mainline. Instead, it looks like mainline will be using the mbed_create_distro feature that merged in ARMmbed/mbed-os#15126 instead.
We should probably pull in the latest official upstream release (patched with our can fixes), and port our repo to use mbed_create_distro. As it stands, our fw repo is using a version of mbed thats missing ~a years worth of bugfixes, features, etc

The CAN patch was merged upstream actually in ARMmbed/mbed-os#14612

So we should be able to go back to using mainline mbed, right? no other patches we made that havent been upstreamed already?

@cindyli-13
Copy link
Member

cindyli-13 commented Jan 16, 2022

This repo currently uses a fork of mbed feauture branch feature-cmake-object-libraries that was patched by me to pull in a fix for STM32 targets(which has since been officially released upstream), and then patched by @cindyli-13 to provide several can fixes(I don't think these fixes were merged upstream but @cindyli-13 can confirm).
According to discussion in ARMmbed/mbed-os#13981, it seems like upstream mbed has gone a different direction and it looks like the feature-cmake-object-libraries is not going to be merged into mainline. Instead, it looks like mainline will be using the mbed_create_distro feature that merged in ARMmbed/mbed-os#15126 instead.
We should probably pull in the latest official upstream release (patched with our can fixes), and port our repo to use mbed_create_distro. As it stands, our fw repo is using a version of mbed thats missing ~a years worth of bugfixes, features, etc

The CAN patch was merged upstream actually in ARMmbed/mbed-os#14612

So we should be able to go back to using mainline mbed, right? no other patches we made that havent been upstreamed already?

As far as I'm aware yes. Unless there were patches other than the CAN patch that aren't in mainline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants