-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cmake to use mbed_create_distro and latest mbed release #404
Comments
It would be the best to use |
The feature branch did work for us and I found it fairly painless to migrate to that feature branch ~9 months ago. Not sure how much work it will be for us to go from the feature branch to using |
The CAN patch was merged upstream actually in ARMmbed/mbed-os#14612 |
So we should be able to go back to using mainline mbed, right? no other patches we made that havent been upstreamed already? |
As far as I'm aware yes. Unless there were patches other than the CAN patch that aren't in mainline. |
This repo currently uses a fork of mbed feauture branch
feature-cmake-object-libraries
that was patched by me to pull in a fix for STM32 targets(which has since been officially released upstream), and then patched by @cindyli-13 to provide several can fixes(I don't think these fixes were merged upstream but @cindyli-13 can confirm).According to discussion in ARMmbed/mbed-os#13981, it seems like upstream mbed has gone a different direction and it looks like the
feature-cmake-object-libraries
is not going to be merged into mainline. Instead, it looks like mainline will be using thembed_create_distro
feature that merged in ARMmbed/mbed-os#15126 instead.We should probably pull in the latest official upstream release (patched with our can fixes), and port our repo to use
mbed_create_distro
. As it stands, our fw repo is using a version of mbed thats missing ~a years worth of bugfixes, features, etcThe text was updated successfully, but these errors were encountered: