You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug for STM devices that make use of dual CAN instances where the slave start filter bank is not set correctly. Previously, filters cannot be set for the slave CAN instance since the slave start filter bank is always set to a higher index than the filter bank to be configured. See #14596 for full description.
Impact of changes
Migration actions required
Documentation
None
Pull request type
[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)
Test results
[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR
Sorry for long delay...
But your patch is for dual CAN instances ?
We should set SlaveStartFilterBank as well ?
Is patch still compatible with single CAN MCU ?
After more checks, answer is no...
as current ST porting API is not using the ST CAN drivers (STM32Cube_FW/STM32XXxx_HAL_Driver/stm32XXxx_hal_can.c)
but the "legacy" one (STM32Cube_FW/STM32XXxx_HAL_Driver/Legacy/stm32XXxx_hal_can_legacy.c)
@jeromecouant My patch will dedicate filters 0-13 for CAN instance 1 and filters 14-27 for CAN instance 2, so I think for single CAN cases only filters 0-13 can be used.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ciarmcom
added
the
release-type: patch
mbedmain
removed
release-type: patch
Summary of changes
Fixes a bug for STM devices that make use of dual CAN instances where the slave start filter bank is not set correctly. Previously, filters cannot be set for the slave CAN instance since the slave start filter bank is always set to a higher index than the filter bank to be configured. See #14596 for full description.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers