getRandomValues couldn't be found from a WebWorker in Edge18

[evertbouw]

Describe the bug

I've used uuid v4 in a webworker but now I'm seeing error logs from Edge18.

SCRIPT0: SCRIPT0: uuid: This browser does not seem to support crypto.getRandomValues(). If you need to support this browser, please provide a custom random number generator through options.rng.
27788d0bfdaa0d0b9446.worker.js (2,1)

Runtime

• OS: Windows 10
• Runtime: Edge
• Runtime Version: EdgeHTML 18.19041

[ctavan]

@evertbouw can you please provide steps to reproduce as requested by the issue template? Thanks!

[evertbouw]

I thought that would look a little bit silly as it's just repeating call v4 in a webworker in Edge, but I'll try to get a minimal repro online

[evertbouw]

live: https://evertbouw.github.io/buggy-edge/
code: https://github.com/evertbouw/buggy-edge/blob/master/src/foo.worker.js

[ctavan]

Thank you for the reproduction code, that was really helpful!

Unfortunately, according to https://caniuse.com/#feat=cryptography, the WebCrypto API is not supported in WebWorkers in Edge<=18.

There was an issue regarding that problem on the old Edge Issuetracker which is no longer available: https://web.archive.org/web/20171210184325/https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/7607496/

Unfortunately this means that if you want to continue to support pre-Chromium Edge Versions you will either have to continue to use [email protected] or you have to supply your own random number generator to the v4() method through options.rng.

You could take a look at the old version of this library where we were shipping an insecure fallback random number generator for environments that do not support proper cryptographically secure random number generators: https://github.com/uuidjs/uuid/blob/v3.4.0/lib/rng-browser.js#L24-L33

However, please be aware that using a flawed random number generator might lead to unexpected consequences, see https://github.com/tc39/proposal-uuid#how-unique-are-v4-uuids for examples.

[broofa]

@ctavan 'worth noting that this a perfect example of why Math.getRandomValues() is needed.

[evertbouw]

Thanks!

I wasn't sure if this was intended because I couldn't really find anything on Google. In my worker I guess I used uuid out of habit but an auto increment id should suffice so I'm doing that now.