Not available within web worker context

[nickpeihl]

I have an idea of using hyperdb and random-access-idb in a web worker context with webworkify, but I am getting an error message in the browser that says "Cannot find module 'crypto'".

I've narrowed it down to the randombytes module in sodium-javascript. The window global is not available in a web worker context so the crypto variable is set to null in this line. This block determines which crypto.getRandomValues function to use. However, it does not have any checks for a web worker context. Most evergreen browsers support the crypto functions in web workers (Edge is an exception).

I'm still unsure the best way to achieve this, but I will play with a few things and submit a PR if I find something suitable. I appreciate any input.

Here's a gist showing the code I'm using. I run it with budo index.js. The browser console should show the error. https://gist.github.com/nickpeihl/0996c84667fc0defc76642ae0af4518a

[emilbayes]

I'm thinking of simply changing this line:

sodium-javascript/randombytes.js

Line 4 in 5511baf

var crypto = typeof window !== 'undefined' ? (window.crypto || window.msCrypto) : null

to:

var crypto = typeof window !== 'undefined' ? (window.crypto || self.crypto || window.msCrypto) : null

Thanks for the detailed bug report!

[emilbayes]

Ah so the trick is to change the line to:

var crypto = typeof global !== 'undefined' ? crypto = (global.crypto || global.msCrypto) : null

and browserify will handle picking either self or window

I will make an update and release a patch. If you want street creds you can make a PR for a test case, eg with your project sending some random bytes back from the webworker ^^

[emilbayes]

Fixed in 0.5.2 :)

[nickpeihl]

😍 thanks so much!