Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing tests after #127 -- some fixable now; some have to wait #131

Open
5 tasks done
jGaboardi opened this issue Aug 1, 2024 · 1 comment
Open
5 tasks done
Assignees

Comments

@jGaboardi
Copy link
Collaborator

jGaboardi commented Aug 1, 2024

Following #127, we have failures due to data being updated. Some we can fix now, some we can't

  • test_protocol.py::test_generate_case[original] - assert 25 == 17 - deleted service roads #161
  • test_protocol.py::test_process_case_original[png] - deleted service roads #161
  • test_utils.py::test_read_original - 72b5229
    • [Aleppo-86101] - assert 78908 == 86101
    • [Auckland-109976] - assert 60364 == 109976
    • [Bucaramanga-110074] - assert 79317 == 110074
    • [Salt Lake City-110211] - assert 50917 == 110211
    • [Douala-88746] - assert 84819 == 88746
    • [Li\xe8ge-105174] - assert 79907 == 105174
    • [Wuhan-107551] - assert 92667 == 107551
  • test_utils.py::test_read_no_degree_2 - 603d01d
    • [Bucaramanga-23127] - assert 16302 == 23127
    • [Aleppo-46179] - assert 43233 == 46179
    • [Douala-32020] - assert 30552 == 32020
    • [Auckland-40177] - assert 12439 == 40177
    • [Li\xe8ge-28597] - assert 16554 == 28597
    • [Salt Lake City-46362] - assert 13468 == 46362
  • test_common.py::TestContinuity::test_basic - 1b7816b
FAILED core/tests/test_protocol.py::test_generate_case[original] - assert 25 == 17
FAILED core/tests/test_protocol.py::test_process_case_original[png] - matplotlib.testing.exceptions.ImageComparisonFailure: images not close (RMS 7.202):
	result_images/test_protocol/test_process_case_original.png
	result_images/test_protocol/test_process_case_original-expected.png
	result_images/test_protocol/test_process_case_original-failed-diff.png
FAILED core/tests/test_utils.py::test_read_original[Aleppo-86101] - assert 78908 == 86101
FAILED core/tests/test_utils.py::test_read_original[Auckland-109976] - assert 60364 == 109976
FAILED core/tests/test_utils.py::test_read_original[Bucaramanga-110074] - assert 79317 == 110074
FAILED core/tests/test_utils.py::test_read_original[Salt Lake City-110211] - assert 50917 == 110211
FAILED core/tests/test_utils.py::test_read_original[Douala-88746] - assert 84819 == 88746
FAILED core/tests/test_utils.py::test_read_original[Li\xe8ge-105174] - assert 79907 == 105174
FAILED core/tests/test_utils.py::test_read_original[Wuhan-107551] - assert 92667 == 107551
FAILED core/tests/test_utils.py::test_read_no_degree_2[Bucaramanga-23127] - assert 16302 == 23127
FAILED core/tests/test_utils.py::test_read_no_degree_2[Aleppo-46179] - assert 43233 == 46179
FAILED core/tests/test_utils.py::test_read_no_degree_2[Douala-32020] - assert 30552 == 32020
FAILED core/tests/test_utils.py::test_read_no_degree_2[Auckland-40177] - assert 12439 == 40177
FAILED core/tests/test_utils.py::test_read_no_degree_2[Li\xe8ge-28597] - assert 16554 == 28597
FAILED core/tests/test_utils.py::test_read_no_degree_2[Salt Lake City-46362] - assert 13468 == 46362
FAILED core/tests/test_utils.py::test_read_no_degree_2[Wuhan-35869] - assert 29314 == 35869
FAILED core/tests/test_common.py::TestContinuity::test_basic - AssertionError: DataFrame.iloc[:, 1] (column name="count") are different

DataFrame.iloc[:, 1] (column name="count") values are different (100.0 %)
[index]: [0, 1]
[left]:  [15306, 13291]
[right]: [8570, 7984]
FAILED core/tests/test_utils.py::test_make_grid - assert 285 == 294
FAILED core/tests/test_viz_h3_hex.py::TestVizH3HexPlotCell::test_loc_id[png] - matplotlib.testing.exceptions.ImageComparisonFailure: images not close (RMS 34.461):
	result_images/test_viz_h3_hex/test_viz_h3_hex_plot_cell_loc_id.png
	result_images/test_viz_h3_hex/test_viz_h3_hex_plot_cell_loc_id-expected.png
	result_images/test_viz_h3_hex/test_viz_h3_hex_plot_cell_loc_id-failed-diff.png
FAILED core/tests/test_viz_h3_hex.py::TestVizH3HexPlotCell::test_hex_id[png] - matplotlib.testing.exceptions.ImageComparisonFailure: images not close (RMS 9.392):
	result_images/test_viz_h3_hex/test_viz_h3_hex_plot_cell_hex_id.png
	result_images/test_viz_h3_hex/test_viz_h3_hex_plot_cell_hex_id-expected.png
	result_images/test_viz_h3_hex/test_viz_h3_hex_plot_cell_hex_id-failed-diff.png
================= 20 failed, 33 passed, 14 warnings in 49.90s ==================
@jGaboardi jGaboardi self-assigned this Aug 1, 2024
martinfleis pushed a commit that referenced this issue Aug 1, 2024
* fix test_read_original--() failures

* fix test_read_no_degree_2--() failures

* fix test_make_grid--() failure

* fix TestContinuity::test_basic failure
@jGaboardi
Copy link
Collaborator Author

jGaboardi commented Aug 18, 2024

3 remaining XFAIL/XPASS

XFAIL core/tests/test_viz_h3_hex.py::TestVizH3HexPlotCell::test_hex_id[png] - Needs updated Manual & Parenx -- See GH#131.
XFAIL core/tests/test_viz_h3_hex.py::TestVizH3HexPlotCell::test_loc_id[png] - Needs updated Manual & Parenx -- See GH#131.
XPASS core/tests/test_viz_h3_hex.py::test_viz_h3_hex_plot_analysis[png] - Needs updated Manual & Parenx -- See GH#131.
  • test_viz_h3_hex.py::TestVizH3HexPlotCell::test_hex_id[png]
  • test_viz_h3_hex.py::TestVizH3HexPlotCell::test_loc_id[png]
  • test_viz_h3_hex.py::test_viz_h3_hex_plot_analysis[png]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant