Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-429: Add config and po files from Amharic. #544

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

daniel-crowder
Copy link
Contributor

@daniel-crowder daniel-crowder commented Feb 8, 2024

Jira ticket

VOTE-429

Description

Add PO and Config files to enable and provide string translations for Amharic.

Deployment and testing

Pre-deploy

n/a

Post-deploy

  1. Locally, run lando retune -y to import config files and string translations from PO file.

QA/Test

  1. Visit http://vote-gov.lndo.site/admin/config/regional/language and confirm that Amharic language is listed.
  2. Visit http://vote-gov.lndo.site/admin/config/regional/translate
  3. Do a search using the following: Translation: Amharic, Search In: Only translated strings
  4. Confirm that the search returns a list of translated strings for Amharic.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada merged commit 774fe79 into dev Feb 13, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-429-add-amharic-translation branch February 14, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants