USAGOV-1983-New-Menu-Color

[IsabelLaurenceau]

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-1983

Description

Changed the vertical bar of current page back to #D83933

Type of Changes

• New Feature
• Bugfix
• Frontend (Twig, Sass, JS)
  • Add screenshot showing what it should look like
• Drupal Config (requires "drush cim")
• New Modules (requires rebuild)
• Documentation
• Infrastructure
  • CMS
  • WAF
  • WWW
  • Egress
  • Tools
  • Cron
• Other

Testing Instructions

Change Requirements

• Requires New Documentation (Link: {})
• Requires New Config
• Requires New Content

Validation Steps

• Go to any second level page (i.e http://localhost/immigration-case-status or http://localhost/government-grants-and-loans)
• Make sure that the left vertical bar on the menu is #D83933 but the text is #AE1A0A
  

Security Review

• Adds/updates software (including a library or Drupal module)
• Communication with external service
• Changes permissions or workflow
• Requires SSPP updates

Reviewer Reminders

• Reviewed code changes
• Reviewed functionality
• Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

1. Go to the USAGov Circle CI project.
2. Find the commit of this pull request.
3. Build and deploy the changes.
4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

[akf]

@IsabelLaurenceau the changes showing up on this PR don't match the description, which confused me. In fact, they look like the same changes as #2002, which has already been merged.
It looks like the intended change got merged into dev in one of the commits listed here. Could you take a look and verify my understanding on the color change?
(I'm puzzled as to why the changed files show up the way they do in this PR, but 🤷 )

[IsabelLaurenceau]

Amy you are right. I must have messed something up on my end when working with this ticket. I'm still not sure how based on the files showing in this PR and what's on dev but I am investigating now

[IsabelLaurenceau]

Closing this one (still looking to see what happened) but creating a new PR to address Nicole's Jira comment.