Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV 1366 Rename A11y and Lookup Scripts #2002

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

IsabelLaurenceau
Copy link
Collaborator

Jira Task

Renamed the scripts to better show their purpose

https://cm-jira.usa.gov/browse/USAGOV-1366

Description

Renamed the scripts to better show their purpose. Also changed or indicated where their source names need to be changed.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  • For English:

    • Go to http://localhost/elected-officials-results and click edit
    • Scroll to footer HTML
    • Replace <script src="/themes/custom/usagov/scripts/lookup.js" defer></script> with
      <script src="/themes/custom/usagov/scripts/ceoResults.js" defer></script>
  • For Spanish:

  • Fill out CEO form for both languages. Make sure they are working as expected

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@IsabelLaurenceau IsabelLaurenceau marked this pull request as ready for review October 10, 2024 13:03
@developer43 developer43 self-requested a review October 10, 2024 14:20
@developer43 developer43 merged commit 27dfad1 into dev Oct 10, 2024
5 of 6 checks passed
@developer43 developer43 deleted the USAGOV-1366-Rename-Scripts branch October 10, 2024 14:31
@akf akf mentioned this pull request Oct 10, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants