Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Гафурова Софья #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,192 changes: 596 additions & 596 deletions package-lock.json

Large diffs are not rendered by default.

21 changes: 20 additions & 1 deletion tasks/1.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,25 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
div
{
background: #6698ff;
}

#id
{
background: #98ff66;
}

.c1
{
background: #ff6698;
}

aside

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно объединить с первым

{
background: #6698ff;
}
</style>

<section class="global-result">
Expand All @@ -37,3 +55,4 @@ <h1 class="global-heading">&nbsp;</h1>
<script src="../global.js"></script>
</body>
</html>

10 changes: 9 additions & 1 deletion tasks/10.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,15 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
.title:first-letter
{
color: #ff6698;
}

.description:first-line
{
color: #6698ff;
}
</style>

<section class="global-result">
Expand Down
16 changes: 15 additions & 1 deletion tasks/11.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,21 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
article > input:first-child
{
border: 3px solid #ff6698;
}

article > input:last-child
{
border: 3px solid #98ff66;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

должно зависеть именно от валидности введенного емэйла


article > input:first-child:focus

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

фокус должен работать на обоих инпутах

{
border: 3px solid #6698ff;
}

</style>

<section class="global-result">
Expand Down
27 changes: 26 additions & 1 deletion tasks/12.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,32 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
article > div
{
background: #ff6;
}

article > div:nth-child(1)
{
background: #ffb366;
}

article > div:nth-child(3)
{
background: #ffb366;
}

article > div:nth-child(7)
{
background: #ffb366;
}

article > div:nth-child(9)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно гораздо проще, обрати внимание на то, чем отличаются дивы в верстке

{
background: #ffb366;
}


</style>

<section class="global-result">
Expand Down
16 changes: 15 additions & 1 deletion tasks/13.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,21 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
article > div:first-child > div:first-child
{
background: #ff6698;
}

article > div:nth-child(5) > div:first-child
{
background: #ff6698;
}

article > div:nth-child(9) > div:first-child

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно гораздо проще, обрати внимание что этот див единственный такого типа в своем родителе

{
background: #ff6698;
}

</style>

<section class="global-result">
Expand Down
6 changes: 5 additions & 1 deletion tasks/14.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
ul li:before

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

кажется, уточнение ul лишнее

{
content: '+';
margin-right: 5px;
}
</style>

<section class="global-result">
Expand Down
6 changes: 5 additions & 1 deletion tasks/15.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
ul > li > a[href$='.zip']::after

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

кажется, уточнение ul > li лишнее

{
content: '↓';
margin-left: 3px;
}
</style>

<section class="global-result">
Expand Down
20 changes: 19 additions & 1 deletion tasks/16.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,25 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
article > div:first-child

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно без first-child

{
background: #ff6698;
}

article > div:nth-child(2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно без nth-child

{
background: #6698ff;
}

#id1
{
background: #ffb366;
}

article > div:last-child

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно без last-child

{
background: #ff6 !important;
}
</style>

<section class="global-result">
Expand Down
10 changes: 9 additions & 1 deletion tasks/17.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,15 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
input:checked
{
outline: none !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

надо сделать без important, important - зло, так как его сложно переопределить потом

}

input:checked ~ input
{
outline: 1px solid #ff6698;
}
</style>

<section class="global-result">
Expand Down
16 changes: 15 additions & 1 deletion tasks/18.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,21 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
article > div
{
opacity: .5;
}

article > div:hover
{
opacity: 1;

}

article:hover > div:not(:hover)
{
opacity: .25;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

</style>

<section class="global-result">
Expand Down
31 changes: 30 additions & 1 deletion tasks/19.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,36 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
article > div
{
background: #ffb366;
}

article > div > div
{
background: white;
}

article > div:nth-child(1) > div:nth-child(4)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно использовать first-child last-child

{
background: #98ff66;
}

article > div:nth-child(2) > div:nth-child(even)
{
background: #ff6698;
}

article > div:nth-child(3) > div:nth-child(odd)
{
background: #6698ff;
}

article > div:nth-child(4) > div:first-child
{
background: #ff6;
}

</style>

<section class="global-result">
Expand Down
16 changes: 15 additions & 1 deletion tasks/2.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,21 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
.c1
{
background: #ff6698;
border: 2px solid #000;
}

.c2
{
background: #ffb366;
}

.c1.c2
{
background: #6698ff;
}
</style>

<section class="global-result">
Expand Down
16 changes: 15 additions & 1 deletion tasks/20.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,21 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
.global-scope > .red-gt2 > div
{
background: #ff6698;
}

.global-scope > .red-gt2 > div:nth-child(1):nth-last-child(1)
{
background: white;
}

.global-scope > .red-gt2 > div:nth-child(1):nth-last-child(2),
.global-scope > .red-gt2 > div:nth-child(2):nth-last-child(1)
{
background: white;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
(но можно было проще)

</style>

<section class="global-result">
Expand Down
11 changes: 10 additions & 1 deletion tasks/3.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,16 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
div
{
border: 2px solid black;
}

div > div
{
border: none;
background: #6698ff;
}
</style>

<section class="global-result">
Expand Down
15 changes: 14 additions & 1 deletion tasks/4.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,20 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
article > article:nth-child(even)
{
background: #ff6;
}

article > article
{
border-top: 1px solid black;
}

p + hr + article

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

плохо привязывать к тому, что до article, так как это может поменяться
попробуй использовать +

{
border-top: none;
}
</style>

<section class="global-result">
Expand Down
6 changes: 5 additions & 1 deletion tasks/5.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
#checkbox:checked + br + .tab

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут та же проблема, а что если br уберем или добавим еще один?

{
color: white;
background: black;
}
</style>

<section class="global-result">
Expand Down
15 changes: 14 additions & 1 deletion tasks/6.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,20 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
[href='https://vk.ru']
{
color: #6698ff;
}

[href='https://yandex.ru']
{
color: #ff6698;
}

[href='https://market.yandex.ru/']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно сделать проверку не на полное совпадение и объединить с предыдущим

{
color: #ff6698;
}
</style>

<section class="global-result">
Expand Down
10 changes: 9 additions & 1 deletion tasks/7.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,15 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
article > div:nth-child(2)
{
opacity: .5;
}

article > div:nth-child(3)
{
opacity: .5;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно проще, обрати внимание, чем отличаются картинки в верстке

</style>

<section class="global-result">
Expand Down
Loading