-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Гафурова Софья #124
base: master
Are you sure you want to change the base?
Гафурова Софья #124
Conversation
🍏 Пройден линтинг и базовые тесты |
background: #ff6698; | ||
} | ||
|
||
aside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
можно объединить с первым
article > input:last-child | ||
{ | ||
border: 3px solid #98ff66; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
должно зависеть именно от валидности введенного емэйла
border: 3px solid #98ff66; | ||
} | ||
|
||
article > input:first-child:focus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
фокус должен работать на обоих инпутах
background: #ffb366; | ||
} | ||
|
||
article > div:nth-child(9) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
можно гораздо проще, обрати внимание на то, чем отличаются дивы в верстке
background: #ff6698; | ||
} | ||
|
||
article > div:nth-child(9) > div:first-child |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
можно гораздо проще, обрати внимание что этот див единственный такого типа в своем родителе
color: #ff6698; | ||
} | ||
|
||
[href='https://market.yandex.ru/'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
можно сделать проверку не на полное совпадение и объединить с предыдущим
article > div:nth-child(3) | ||
{ | ||
opacity: .5; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
можно проще, обрати внимание, чем отличаются картинки в верстке
[href*='ya.ru'] | ||
{ | ||
color: #ff6698; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
это не показатель того, что внешние относительно my-site, лучше сделать универсально, проверяя на то, что это не ссылка на my-site
} | ||
|
||
.link:nth-child(2):hover, | ||
.link:nth-child(2):visited:hover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
черносерыми должны быть именно псевдоссылки (без урла), а не вторая в списке
а все остальные - цветные
@@ -12,7 +12,32 @@ <h1 class="global-heading"> </h1> | |||
|
|||
<main class="global-results"> | |||
<style> | |||
/* your styles here */ | |||
[href*='ya.ru']:hover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
при ховере посещенной ссылки не меняется цвет
Посмотреть решение