Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly check if the TextBox is PasswordBox before obscuring text #6804

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): Addresses regression introduced in #6768, and also fixes the implementation of the same PR

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • TextBox was incorrectly obscuring text.
  • PasswordBox wasn't correctly accounting for programmatically changes of reveal mode

What is the new behavior?

Fix both problems.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 requested a review from a team August 19, 2021 11:34
@gitpod-io
Copy link

gitpod-io bot commented Aug 19, 2021

@davidjohnoliver davidjohnoliver merged commit 7e5f868 into unoplatform:master Aug 20, 2021
@Youssef1313 Youssef1313 deleted the skia-textbox branch August 20, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants