-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support PasswordBox on Skia #6768
Conversation
src/Uno.UI.Runtime.Skia.Gtk/UI/Xaml/Controls/TextBoxViewExtension.cs
Outdated
Show resolved
Hide resolved
@Youssef1313 There was a regression reported on Discord, I'm guessing it's related to this PR. I can repro with the following XAML in a new app using latest Uno.UI: <StackPanel Background="{ThemeResource ApplicationPageBackgroundThemeBrush}" Margin="30">
<Button Content="dummy" />
<TextBox Text="should be a normal textbox"/>
</StackPanel> On Skia.Gtk the Could you take a look into it? The report on Discord:
|
@@ -45,7 +45,7 @@ public TextBoxView(TextBox textBox) | |||
|
|||
internal void SetTextNative(string text) | |||
{ | |||
DisplayBlock.Text = text; | |||
DisplayBlock.Text = new string('•', text.Length); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem should probably be here. I'll take a look to confirm and fix. Sorry for introducing such a regression :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, happens to everybody. :)
For my part, I somehow did not even notice this line when I reviewed the PR.
I'm noticing other issues with TextBox on Gtk when running Samples App:
I reverted my commits locally to make sure these issues are unrelated to my changes and indeed they're unrelated. I also found that my implementation doesn't only break TextBox, but breaks PasswordBox itself when RevealMode is set programmatically (not through the reveal button). But I wasn't able to completely fix that. |
GitHub Issue (If applicable): closes #6396, closes #5767
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No support for PasswordBox on Skia GTK
What is the new behavior?
Supported
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):