feat: [macOS] Support media player #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
8 tasks
jeromelaban
approved these changes
May 4, 2020
|
Thanks @MartinZikmund ! |
MartinZikmund
force-pushed
the
dev/mazi/mediaplayer-macos
branch
from
22bd36e to
efb6b08
Compare
MartinZikmund
added
the
ready-to-merge
…yer-macos # Conflicts: # src/Uno.UWP/Generated/3.0.0.0/Windows.Media.Playback/MediaPlaybackItem.cs # src/Uno.UWP/Generated/3.0.0.0/Windows.Media.Playback/MediaPlaybackList.cs
agneszitte
approved these changes
May 29, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
|
@MartinZikmund could you please rebase master? Thanks :) |
Will do 👍 |
# Conflicts: # src/Uno.UI/Generated/3.0.0.0/Windows.UI.Xaml.Controls/MediaPlayerElement.cs # src/Uno.UI/Generated/3.0.0.0/Windows.UI.Xaml.Controls/MediaTransportControls.cs # src/Uno.UI/UI/Xaml/Controls/MediaPlayer/MediaTransportControls.MediaPlayer.cs # src/Uno.UI/UI/Xaml/Controls/MediaPlayer/MediaTransportControls.cs
|
@ajpinedam Merged 👍 |
dr1rrb
approved these changes
Jun 23, 2020
| @@ -130,7 +130,10 @@ protected override Size MeasureOverride(Size availableSize) | |||
| if (double.IsNaN(Width) && double.IsNaN(Height)) | |||
| { | |||
| availableSize.Width = availableSize.Width; | |||
| availableSize.Height = availableSize.Width / _currentRatio; | |||
| if (_currentRatio != 0) | |||
There was a problem hiding this comment.
Good catch! You should apply it also for the if (double.IsNaN(Height)) case :)
| @@ -114,6 +137,22 @@ internal void RaiseNativeSizeChanged(CGSize size) | |||
| } | |||
| } | |||
|
|
|||
| internal void DisplayFullscreen(UIElement element) | |||
There was a problem hiding this comment.
It's actually not really "full screen" but "full window". Probably sufficient for now, but I don't known if it would be easy to really go full screen on mac ?
|
@MartinZikmund thank you!. The CI is complaining, I will be looking into those issues and updating the PR. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #626, closes: #3020
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Not supported.
What is the new behavior?
Supported.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):