Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS release builds seem to depend on QTKit #3524

Closed
2 of 12 tasks
mattleibow opened this issue Jul 12, 2020 · 7 comments
Closed
2 of 12 tasks

macOS release builds seem to depend on QTKit #3524

mattleibow opened this issue Jul 12, 2020 · 7 comments
Assignees
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools

Comments

@mattleibow
Copy link

mattleibow commented Jul 12, 2020

Current behavior

When building a macOS app in release configuration, I get a warning about referencing QTKit.

  Target _CompileToNative:
    /Library/Frameworks/Xamarin.Mac.framework/Versions/Current/bin/mmp @/Users/runner/work/1/s/output/samples/Basic/Uno/SkiaSharpSample.macOS/obj/Release/response-file.rsp -q
     -q
     -q
     -q
     
    MMP : warning MM5220: Skipping framework 'QTKit'. It is prohibited (rejected) by the Mac App Store [/Users/runner/work/1/s/output/samples/Basic/Uno/SkiaSharpSample.macOS/SkiaSharpSample.macOS.csproj]
  Done building target "_CompileToNative" in project "SkiaSharpSample.macOS.csproj".

I am not sure exactly what/where this comes from. All I have added in my sample is Uno, I have a macOS app building/archiving fine in release.

Expected behavior

Not have the app reference QTKit.

How to reproduce it (as minimally and precisely as possible)

Still going to create a minimal sample, but I got a binlog that may be helpful now:
msbuild.zip

I have my PR that works, just get a build warning. There is a lot of sample assets, but not much extra code:
mono/SkiaSharp#1396

EDIT

Here is a sample:

Archive.zip
Binlog: msbuild.binlog.zip

Environment

Nuget Package: Uno.UI

Package Version(s): 2.4.0

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Windows
  • Build tasks
  • Solution Templates

Visual Studio:

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?

@mattleibow mattleibow added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Jul 12, 2020
@jeromelaban
Copy link
Member

Thanks Matthew!

I don't believe Uno is having any explicit dependency on QTKit (the sample app inside of uno does not generate this message).

I wonder if it could be related to #3021. If this is the case, it would mean that a media playback app would not be allowed on the store ?

@mattleibow
Copy link
Author

mattleibow commented Jul 12, 2020

@jeromelaban I updated the issue with a minimal sample that does this, and added the new binlog

EDIT
also added version info

@mattleibow
Copy link
Author

That PR adds AVFoundation, which is fine for macOS.

@jeromelaban jeromelaban removed the triage/untriaged Indicates an issue requires triaging or verification label Jul 14, 2020
@francoistanguay francoistanguay modified the milestone: 3.1 Aug 29, 2020
@agneszitte agneszitte added the project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools label Sep 21, 2020
@jeromelaban jeromelaban added the difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. label Feb 15, 2021
@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jun 1, 2021
@MartinZikmund
Copy link
Member

@ajpinedam adding you here, not urgent, but if anyone has a chance to debug this, then it is you 😀

@MartinZikmund MartinZikmund added the platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform label Jun 1, 2021
@jeromelaban
Copy link
Member

It looks like this issue may be addressable with the new "feature"-based linking of .NET 6.

@ajpinedam
Copy link
Contributor

@jeromelaban @MartinZikmund @mattleibow this issue #5152 from the the xamarin.macios repository has some information related to this warning.

The warning seems to be harmless when you are not shipping the app to the App Store, in case you are the app could get rejected. To resolve this issue they suggest adding some kind of linking

This direct comment on the issue has more information.

@jeromelaban
Copy link
Member

Let's close this issue for now then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools
Projects
None yet
Development

No branches or pull requests

6 participants