add base64 dependency for future-proofing #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the heads up and the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working in anchordotdev/puma-acme we started getting a failure against head ruby, because it no longer has base64 in stdlib, and instead you have to explicitly require it. You can see the error here:
https://github.com/anchordotdev/puma-acme/actions/runs/10150742999/job/28068516562
We added it ourselves to immediately address the issue, but wanted to pass the fix upstream to you as well. I don't believe it should change any current behavior, and should help future proof things so you won't need to address this when 3.4+ appear.
Just let me know if you have any questions or I can help further to land this. Thanks!