Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: remove base64 dependency after upcoming acme-client release #22

Closed
geemus opened this issue Jul 30, 2024 · 0 comments · Fixed by #20
Closed

TODO: remove base64 dependency after upcoming acme-client release #22

geemus opened this issue Jul 30, 2024 · 0 comments · Fixed by #20

Comments

@geemus
Copy link
Contributor

geemus commented Jul 30, 2024

When we removed sinatra, we started seeing errors against head ruby because the base64 gem was no longer a downstream dependency and it is no longer stdlib in 3.4+.

So, we added the direct dependency to clear the error.

We don't directly even use base64 though, and just inherit the dependency from our usage of acme-client. As such, I made an upstream PR to address the issue there, which has subsequently been merged: unixcharles/acme-client#241

So now, once acme-client has released again we should follow up with removing it here again to simplify and avoid potential dependency version issues moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant