Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop sintra dependency and require #20

Merged
merged 2 commits into from
Oct 15, 2024
Merged

drop sintra dependency and require #20

merged 2 commits into from
Oct 15, 2024

Conversation

geemus
Copy link
Contributor

@geemus geemus commented Jul 29, 2024 •
edited
Loading

closes #22

benburkert
benburkert approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@benburkert benburkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geemus
Copy link
Contributor Author

geemus commented Oct 15, 2024

Cycling to try and kick off CI.

@geemus geemus closed this Oct 15, 2024
@geemus geemus reopened this Oct 15, 2024
@geemus
Copy link
Contributor Author

geemus commented Oct 15, 2024

Had to re-enable actions, trying to cycle again...

@geemus geemus closed this Oct 15, 2024
@geemus geemus reopened this Oct 15, 2024
@geemus geemus merged commit 0558b1d into main Oct 15, 2024
5 checks passed
@geemus geemus deleted the drop-sinatra-dep branch October 15, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benburkert benburkert benburkert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TODO: remove base64 dependency after upcoming acme-client release
2 participants
@geemus @benburkert