Fix global tqdm module patch in test #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2319 +/- ##
==========================================
+ Coverage 98.19% 98.22% +0.02%
==========================================
Files 87 87
Lines 4052 4052
==========================================
+ Hits 3979 3980 +1
+ Misses 73 72 -1 ☔ View full report in Codecov by Sentry. |
|
The test (macos-latest, 3.9) build failing is because of actions/setup-python#696 |
FarLab
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the patch of tqdm happens in a context manager, the fact that the module is reloaded inside the context makes it so that the patch affects all other tests. No test wasn't failing, because there was no assert on tqdm being there, but codecov reports were affected by this, i.e., this PR fixes #2318.