-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Unit Tests #2365
Comments
Happy to go through this exercise, with the caveat that one could make the The Case Against 100% Code Coverage. |
The caveat is understandable. I don't go by the coverage percentage. That value fluctuates inconsistently and it's still not clear to me how it is calculated. Typically, I look at the uncovered lines in the pytest coverage report to make pytest ignore some lines from the coverage report or add unit tests. Perhaps we should discuss what type of unit tests should be added and which ones could be ignored. For example, I don't think we need unit tests for Lines 26 to 29 in aefc5ce
|
Closely related to this issue, the following lines are ignored in the pytest coverage report. A unit test could be added to raise the error similar to some of the changes in #2366 Unless I am missing something and we can't raise this error? mitiq/mitiq/pec/representations/damping.py Lines 75 to 77 in aefc5ce
|
Noticed some lines in the following files show up as uncovered by unit tests in the pytest coverage report. This issue is to figure out if these lines require additional unit tests or if they erroneously show up as uncovered in the pytest report.
mitiq/shadows/quantum_processing.py: L 140Ignored temporarily due to Make changes to the functions inmitiq.shadows
#2129mitiq/shadows/shadows.py: L 68, 73, 78, 137Ignored temporarily due to Make changes to the functions inmitiq.shadows
#2129mitiq/shadows/shadows_utils.py: L 61, 88, 91-96Ignored temporarily due to Make changes to the functions inmitiq.shadows
#2129Will update the issue description later with more details about the specific lines.The text was updated successfully, but these errors were encountered: