[RFC][UN-14216] Remove deprecation warnings from ember-cli-uniq #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreJoaquim
suggested changes
Aug 27, 2018
package.json
Outdated
| @@ -54,7 +54,7 @@ | |||
| "ember-interpolate-helper": "1.0.0", | |||
| "ember-keyboard": "2.1.10", | |||
| "ember-load-initializers": "^1.0.0", | |||
| "ember-modal-dialog": "0.9.0", | |||
| "ember-modal-dialog": "^2.4.4", | |||
There was a problem hiding this comment.
Bumping two major versions without testing this is all platforms before merging seems risky...
There was a problem hiding this comment.
Was tested on search and offer page. There is only one breaking change (yapplabs/ember-modal-dialog#169) and we're not impacted by it.
AndreJoaquim
approved these changes
Aug 27, 2018
DaniFrancisco
approved these changes
Aug 28, 2018
migueldemoura
force-pushed
the
UN-14216/Remove-deprecation-warnings-from-ember-cli-uniq
branch
from
411a19b to
34a206f
Compare
migueldemoura
deleted the
UN-14216/Remove-deprecation-warnings-from-ember-cli-uniq
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements and removes the deprecation warnings of some imports and ember-modal.