Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC][NI] Fix uni-modal deprecation warnings #235

Closed
wants to merge 1 commit into from
Closed

[RFC][NI] Fix uni-modal deprecation warnings #235

wants to merge 1 commit into from

Conversation

carantunes
Copy link
Contributor

Fix deprecation warning:

Specifying the close action for a modal-dialog component is no longer supported in favor of onClose

@AndreJoaquim
Copy link
Contributor

You need to update the addon's version to make this change 😛

@migueldemoura
Copy link
Contributor

I've included this in #261. Closing!

@migueldemoura migueldemoura deleted the NI/fix-uni-modal-deprecation-warnings branch August 28, 2018 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carantunes @AndreJoaquim @migueldemoura