Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metainfo: Clarify requirements, types #192

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

madig
Copy link
Contributor

@madig madig commented Sep 29, 2021

  • ufoLib requires only formatVersion
  • version numbers should logically be non-negative.

@benkiel
Copy link
Contributor

benkiel commented Sep 29, 2021

Hesitant to change the creator requirement (think that ufoLib should be fixed?). I see great value in knowing what produced the ufo. Other changes are good, of course. Open to other opinions on creator (@typesupply @miguelsousa @typemytype @anthrotype)

@typesupply
Copy link
Contributor

What is the rationale for making the creator optional? I'm not arguing against it, just gathering info. The rationale for it being required was for debugging and the kinds of error correction that might be necessary for environment specific file structure mistakes. I have a vague memory of a non-ufoLib writer using the ufoLib creator signature so maybe it's meaningless now.

@madig
Copy link
Contributor Author

madig commented Sep 29, 2021

I merely adapted the spec to what ufoLib is doing (realpolitik) -- if you agree that actually ufoLib should be fixed, I'll drop the optionality.

@typesupply
Copy link
Contributor

I merely adapted the spec to what ufoLib is doing (realpolitik)

Is ufoLib not outputting it all the time? (I haven't looked at how creator is handled in > 10 years.)


I've been giving it some thought... Let's make the creator optional and open an issue to consider deprecating it. It's a meaningless bit of data at this point. For example: if a UFO is created by ufoLib and then 1/2 of the files in it are updated by somethingElseLib, what should the creator be? It's just a bit of data that seemed like a good idea 20 years ago when UFOs were used primarily in import/export situations. It doesn't make sense in the atomic edit situations that are more common today.

@madig
Copy link
Contributor Author

madig commented Sep 29, 2021

It is outputting it I think, but it doesn't read it.

Also, what about e.g. (ufo)normalizers when they rewrite UFOs?

@benkiel benkiel merged commit 424d9b4 into unified-font-object:gh-pages Sep 29, 2021
@benkiel
Copy link
Contributor

benkiel commented Sep 29, 2021

Per @typesupply's comment, I'm merging this and adding a item to deprecate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants