Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MetaInfo to spec #185

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Implement MetaInfo to spec #185

merged 1 commit into from
Sep 29, 2021

Conversation

madig
Copy link
Collaborator

@madig madig commented Sep 28, 2021

@linebender linebender deleted a comment from github-actions bot Sep 28, 2021
@cmyr
Copy link
Member

cmyr commented Sep 29, 2021

Where does it say that creator is optional? (I didn't see this when skimming the spec, assume I've just missed it)

@madig
Copy link
Collaborator Author

madig commented Sep 29, 2021

It didn't, but ufoLib does it that way. I opened unified-font-object/ufo-spec#192 to clarify the spec.

@madig
Copy link
Collaborator Author

madig commented Sep 29, 2021

Amended the PR to contain just the implementation of formatVersionMinor until the spec is clarified about the optionality of creator.

@linebender linebender deleted a comment from github-actions bot Sep 29, 2021
@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing b855c4a against ffbfb82

target old size new size difference
target/release/examples/load_save 1.79 MB 1.79 MB -496 Bytes (-0.03%)
target/debug/examples/load_save 8.3 MB 8.31 MB 16.74 KB (0.20%)

@linebender linebender deleted a comment from github-actions bot Sep 29, 2021
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@madig madig merged commit cb28d9f into master Sep 29, 2021
@madig madig deleted the fresh-metainfo branch September 29, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants