Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update diplomat #5482

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Update diplomat #5482

merged 1 commit into from
Sep 3, 2024

Conversation

Manishearth
Copy link
Member

Lots of changes to JS enums, borrowing, and Option support.

I plan to make use of Option support in a separate PR.

@Manishearth Manishearth requested a review from a team as a code owner September 3, 2024 19:13
@Manishearth Manishearth requested a review from sffc September 3, 2024 19:13
@Manishearth
Copy link
Member Author

autosubmit = on

@sffc
Copy link
Member

sffc commented Sep 3, 2024 

error: package `pulldown-cmark v0.11.2` cannot be built because it requires rustc 1.71.1 or newer, while the currently active rustc version is 1.70.0
Either upgrade to rustc 1.71.1 or newer, or use
cargo update -p [email protected] --precise ver
where `ver` is the latest version of `pulldown-cmark` supporting rustc 1.70.0

rust-diplomat/diplomat#666

@sffc
Copy link
Member

sffc commented Sep 3, 2024

Two choices:

  1. Downgrade the pulldown_cmark to 0.10.0 which is MSRV-compatible
  2. Bump our MSRV version in the icu4x repo

@sffc
Copy link
Member

sffc commented Sep 3, 2024

rust-diplomat/diplomat#672

@Manishearth
Copy link
Member Author

I'm going to rustup us. We'll probably want to do more version updates, but 1.71.1 seems fine for now.

@Manishearth Manishearth mentioned this pull request Sep 3, 2024
Merged
@Manishearth
Copy link
Member Author

#5484

@Manishearth Manishearth merged commit 4514709 into unicode-org:main Sep 3, 2024
28 checks passed
@Manishearth Manishearth deleted the diplomatup branch September 3, 2024 22:32
@makotokato makotokato mentioned this pull request Sep 3, 2024
Merged
sffc pushed a commit that referenced this pull request Sep 3, 2024
@makotokato
Quick fix after rust and diplomat update (#5486)
5e89d20 
For #5482 and
#5484, I have to update
segmenter's generated code due to
#5318
@sffc sffc mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Manishearth @sffc