Update pulldown_cmark #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! |
|
It seems that this version of |
|
@emarteca What feature did you need from the updated pulldown_cmark? Is it in 0.10.0 or only 0.11.0? |
|
(oh I see, it's not about features, it's about vendoring) |
ICU4X does not depend on |
Yes, we've been on a pretty old version of pulldown_cmark for a while |
Or, well, ICU4X's msrv is irrelevant for this, it's only because of choices we've made on CI. But we should update ICU4X MSRV anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're on an old version not in google3, @emarteca is trying to import Diplomat to Google3 and shouldn't have to pull in this dep