Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing datagen features #3339

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Fixing datagen features #3339

merged 3 commits into from
Apr 17, 2023

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Apr 17, 2023 •
edited
Loading

  • SourceData::with_foo_for_tag were not gated behind feature = "networking", which would lead to an unreachable! panic when used without the feature
  • Building with --no-default-features would produce dead code warnings
  • The cached_path dependency wasn't used with dep: so it created an implicit feature

We should do a patch release with this change

@robertbastian robertbastian requested a review from a team as a code owner April 17, 2023 10:10
@robertbastian robertbastian mentioned this pull request Apr 17, 2023
Merged
@robertbastian robertbastian merged commit fbed6df into unicode-org:main Apr 17, 2023
@robertbastian
Copy link
Member Author

@Manishearth could you release I'm afk

@Manishearth
Copy link
Member

on it

@sffc sffc removed their request for review April 20, 2023 15:40
@robertbastian robertbastian deleted the dgf branch April 24, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertbastian @Manishearth