Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump simple_logger to 4.1.0 #3337

Merged
merged 2 commits into from
Apr 18, 2023
Merged

bump simple_logger to 4.1.0 #3337

merged 2 commits into from
Apr 18, 2023

Conversation

pdogr
Copy link
Contributor

@pdogr pdogr commented Apr 17, 2023

Running the command

cargo run --release --bin=icu4x-datagen --all-features -- --icuexport-root=provider/repodata/data/icuexport --syntax=postcard --out=/tmp/icu4x_data --overwrite --keys=segmenter/word@1 --all-locales

leads to the following error

thread 'main' panicked at 'Could not determine the UTC offset on this system. 
Possible causes are that the time crate does not implement "local_offset_at" on your system, 
or that you are running in a multi-threaded environment and the time crate is returning "None" from "local_offset_at" to avoid unsafe behaviour.

Bumping simple_logger to latest fixes this
borntyping/rust-simple_logger#48 (comment)

@pdogr pdogr requested review from sffc, robertbastian, Manishearth and a team as code owners April 17, 2023 09:10
@pdogr pdogr removed request for a team and Manishearth April 17, 2023 09:11
@robertbastian
Copy link
Member

#3338

@robertbastian
Copy link
Member

There's a third usage in ffi/diplomat.

We should probably merge and release #3339 first

Manishearth
Manishearth previously approved these changes Apr 17, 2023
View reviewed changes
robertbastian
robertbastian requested changes Apr 18, 2023
View reviewed changes
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@pdogr pdogr merged commit b3b5c33 into unicode-org:main Apr 18, 2023
sffc
sffc reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

@robertbastian robertbastian robertbastian approved these changes

@Manishearth Manishearth Manishearth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdogr @robertbastian @sffc @Manishearth