Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cache steps from build workflow #235

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Remove cache steps from build workflow #235

merged 1 commit into from
Sep 21, 2020

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Sep 11, 2020

Closes #225

@echeran echeran requested a review from a team as a code owner September 11, 2020 16:56
@coveralls
Copy link

coveralls commented Sep 11, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build d34869ee210a7a2cb19164215f56930d659f709e-PR-235

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.54%
Totals Coverage Status
Change from base Build 1f14b846e6163bac70ce6defa024bbe5d14ae8c8: 0.0%
Covered Lines: 2041
Relevant Lines: 2566
💛 - Coveralls

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran echeran requested a review from zbraniecki September 11, 2020 21:16
@echeran
Copy link
Contributor Author

echeran commented Sep 11, 2020

@zbraniecki Here is the change to remove caching for now, as discussed in the issue. It seems to work -- your PR now gets past build issues and produces a different error. I created a testing PR (#236) to test it out the effect on your PR. I added a TODO + new issue for later for exploring re-enabling caching.

@sffc sffc added the waiting-on-reviewer PRs waiting for action from the reviewer for >7 days label Sep 20, 2020
@sffc
Copy link
Member

sffc commented Sep 20, 2020

Waiting for a review from @zbraniecki

@echeran echeran merged commit 3f3b498 into unicode-org:master Sep 21, 2020
@echeran echeran removed the waiting-on-reviewer PRs waiting for action from the reviewer for >7 days label Sep 21, 2020
@echeran echeran deleted the ci-clear-cache branch October 6, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki approved these changes

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clear stale cache artifacts built against old Rust versions
4 participants
@echeran @coveralls @sffc @zbraniecki