Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear stale cache artifacts built against old Rust versions #225

Closed
echeran opened this issue Sep 3, 2020 · 5 comments · Fixed by #235
Closed

Clear stale cache artifacts built against old Rust versions #225

echeran opened this issue Sep 3, 2020 · 5 comments · Fixed by #235
Assignees
Labels
C-test-infra Component: Integration test infrastructure T-bug Type: Bad behavior, security, privacy
Milestone

Comments

@echeran
Copy link
Contributor

echeran commented Sep 3, 2020

Prompted from build issues in PR #220 - @zbraniecki

Initial idea: if the compatibility of cached build artifacts to the current build also depend on Rust versions matching, then let's add the Rust version to the cache key.

To test: does running the rustc command on the Github Actions runner VMs automatically access the latest stable Rust, or do we need to run a rust command (rustup via actions-rs/toolchain?) to get the latest Rust?

@echeran echeran self-assigned this Sep 3, 2020
@echeran
Copy link
Contributor Author

echeran commented Sep 3, 2020

What's the best way to get the Rust version? Run rustc --version and parse the output?

@zbraniecki
Copy link
Member

@sffc
Copy link
Member

sffc commented Sep 3, 2020

How much time does the cache actually save for us?

I think it's useful to cache things that require a download, but for compile artifacts, maybe we should just not perform caching since it seems to cause a number of problems.

@echeran
Copy link
Contributor Author

echeran commented Sep 3, 2020

Good question. Previously, caching turned a 4-5 min build into 0.5-1.5 min (see #102 (comment)).

But we've already had issues with macOS builds (actions-rs/cargo#111) and turned caching off there (#210), and we've added formatting and linting checks to the build & test workflow, and we're changed the testing step to run over all combinations of features (#172), so the speedup will be less noticeable now.

So I'm inclined to turn off caching and revisit later.

@zbraniecki
Copy link
Member

I'm ok with trying to skip caching and see what happens.

But we should also consider (maybe later?) caching based on Rust version as per https://stackoverflow.com/questions/63521430/clear-cache-in-github-actions

@sffc sffc modified the milestones: 2020 Q4, 2020 Q3 Sep 17, 2020
@sffc sffc added C-test-infra Component: Integration test infrastructure T-bug Type: Bad behavior, security, privacy labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-infra Component: Integration test infrastructure T-bug Type: Bad behavior, security, privacy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants