Add icu-locale macros #220

zbraniecki · 2020-09-03T16:50:26Z

Fixes #75.

jira-pull-request-webhook · 2020-09-03T17:01:17Z

Notice: the branch changed across the force-push!

components/locale/macros/src/lib.rs is different
components/locale/macros/tests/macros.rs is different
components/locale/src/subtags/region.rs is different
components/locale/src/subtags/script.rs is different
components/locale/src/subtags/variant.rs is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2020-09-03T19:10:44Z

Notice: the branch changed across the force-push!

components/locale/macros/src/lib.rs is different
components/locale/macros/tests/macros.rs is different
components/locale/src/parser/langid.rs is now changed in the branch
components/locale/src/subtags/language.rs is different
components/locale/src/subtags/region.rs is different
components/locale/src/subtags/script.rs is different
components/locale/src/subtags/variant.rs is different
components/locale/src/subtags/variants.rs is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2020-09-03T19:14:23Z

Notice: the branch changed across the force-push!

components/locale/src/parser/langid.rs is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2020-09-03T19:15:07Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

zbraniecki · 2020-09-03T19:18:09Z

@echeran I may need your help in getting the actions cache invalidated - the failures are because we use outdated Rust. We should bump to 1.46 which will happen on cache regeneration.

The rest is ready for review!

I had to wrap Variants in Option to allow it to be empty from const fn so that langid! macro works as const. I think it's a small complication that allows for a major usability improvement and it is an internal change that can be safely cleaned up once Rust gains support for Box::new([]) in const fn.

The rest is fairly simple I hope :)

echeran · 2020-09-03T19:36:51Z

I created an issue to separate out the discussion of the cached artifacts causing conflicts - #225

components/locale/macros/src/lib.rs

components/locale/src/subtags/language.rs

components/locale/src/subtags/variants.rs

components/locale/macros/src/lib.rs

jira-pull-request-webhook · 2020-09-17T15:59:53Z

Notice: the branch changed across the force-push!

components/locale/macros/src/lib.rs is different
components/locale/macros/tests/macros.rs is different
components/locale/src/subtags/variants.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

zbraniecki · 2020-09-17T16:01:03Z

I rebased on top of master, added doc comments and improved handling of variants in macro.

This PR is pending release of Rust 1.47 on October 8th (https://forge.rust-lang.org/), but I'd like to get it reviewed and ready for landing prior to that.

components/locale/macros/src/lib.rs

jira-pull-request-webhook · 2020-09-19T21:03:04Z

Notice: the branch changed across the force-push!

components/locale/macros/Cargo.toml is different
components/locale/macros/src/lib.rs is different
components/locale/macros/src/token_stream.rs is now changed in the branch
components/locale/macros/tests/macros.rs is different
components/locale/src/subtags/language.rs is different
components/locale/src/subtags/region.rs is different
components/locale/src/subtags/script.rs is different
components/locale/src/subtags/variant.rs is different
components/locale/src/subtags/variants.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

zbraniecki · 2020-09-19T21:10:22Z

Here and elsewhere (this might be a pre-existing issue): I would avoid using the term "perform canonicalization". UTS 35 defines two types of canonicalization:

I applied your feedback to docs, except of Locale and LanguageIdentifier canonicalize method doc which already stated that we perform "all available levels of canonicalization".

I generally believe that cases where anyone cares about some syntax canonicalization but not form are so extremely rare, that I would like to introduce form canonicalization as an implicit "upgrade" to the functionality without changes to the signature and considered non-breaking.

Since it requires data, we may end up having it behind a feature, in which case user can in theory use that feature to decide if the canonicalization will be syntax only or also form, but I'd like to treat the public API as "we will do everything we can do give you a good output" and if we see a body of need accruing for more specificity, we can then break the API and add options to flip parts of canonicalization.

I updated the docs but I'd like to remove the specifier "syntax" once we land the form canonicalization.

Either way, that's a conversation we can have when we work on form canonicalization and I hope this update unblocks this PR.

jira-pull-request-webhook · 2020-09-19T21:16:14Z

Notice: the branch changed across the force-push!

components/locale/src/subtags/language.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

components/locale/src/subtags/language.rs

components/locale/macros/src/token_stream.rs

jira-pull-request-webhook · 2020-10-07T17:14:07Z

Notice: the branch changed across the force-push!

Cargo.toml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2020-10-08T19:04:57Z

Notice: the branch changed across the force-push!

components/locale/macros/src/token_stream.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc · 2020-10-08T20:24:33Z

components/locale/macros/src/lib.rs

+use proc_macro::TokenStream;
+use token_stream::IntoTokenStream;
+
+fn get_value_from_token_stream(input: TokenStream) -> String {


Looking for literal " is also what you do in tinystr. We need to fix this, but it shouldn't block this PR. zbraniecki/tinystr#24

zbraniecki force-pushed the locale-unchecked branch from f2eb526 to ac3fd08 Compare September 3, 2020 17:01

zbraniecki force-pushed the locale-unchecked branch from ac3fd08 to 81e4597 Compare September 3, 2020 19:10

zbraniecki force-pushed the locale-unchecked branch from 81e4597 to c43f9c7 Compare September 3, 2020 19:14

zbraniecki marked this pull request as ready for review September 3, 2020 19:14

zbraniecki requested review from nciric and a team as code owners September 3, 2020 19:14

zbraniecki force-pushed the locale-unchecked branch from c43f9c7 to 08a41b8 Compare September 3, 2020 19:15

echeran mentioned this pull request Sep 3, 2020

Clear stale cache artifacts built against old Rust versions #225

Closed

sffc requested changes Sep 16, 2020

View reviewed changes

zbraniecki force-pushed the locale-unchecked branch from 08a41b8 to c3041d1 Compare September 17, 2020 15:59

zbraniecki added the waiting-on-reviewer PRs waiting for action from the reviewer for >7 days label Sep 17, 2020

zbraniecki requested a review from sffc September 17, 2020 17:07

zbraniecki mentioned this pull request Sep 18, 2020

Convinience macro naming scheme #253

Closed

sffc reviewed Sep 18, 2020

View reviewed changes

components/locale/macros/src/lib.rs Outdated Show resolved Hide resolved

sffc removed the waiting-on-reviewer PRs waiting for action from the reviewer for >7 days label Sep 18, 2020

zbraniecki force-pushed the locale-unchecked branch from c3041d1 to 3d86024 Compare September 19, 2020 21:02

zbraniecki force-pushed the locale-unchecked branch from e801300 to e6d58e9 Compare September 19, 2020 21:16

sffc previously approved these changes Sep 20, 2020

View reviewed changes

components/locale/src/subtags/language.rs Show resolved Hide resolved

components/locale/macros/src/token_stream.rs Show resolved Hide resolved

components/locale/macros/src/token_stream.rs Show resolved Hide resolved

Add icu-locale macros

5b93eb2

zbraniecki added 2 commits October 7, 2020 10:13

Add docs and improve langid variants handling in the macro.

2e782c8

Apply feedback

cda08cd

zbraniecki dismissed sffc’s stale review via a2c699e October 7, 2020 17:13

zbraniecki force-pushed the locale-unchecked branch from e6d58e9 to a2c699e Compare October 7, 2020 17:13

zbraniecki mentioned this pull request Oct 7, 2020

proc macros ergonomics for ICU4X #310

Closed

Specify in docs that we are performing syntax canonicalization.

6aaefa5

zbraniecki force-pushed the locale-unchecked branch from a2c699e to 6aaefa5 Compare October 8, 2020 19:04

nciric approved these changes Oct 8, 2020

View reviewed changes

sffc approved these changes Oct 8, 2020

View reviewed changes

zbraniecki merged commit 1eae256 into unicode-org:master Oct 8, 2020

zbraniecki deleted the locale-unchecked branch October 19, 2020 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add icu-locale macros #220

Add icu-locale macros #220

zbraniecki commented Sep 3, 2020

jira-pull-request-webhook bot commented Sep 3, 2020

jira-pull-request-webhook bot commented Sep 3, 2020

jira-pull-request-webhook bot commented Sep 3, 2020

jira-pull-request-webhook bot commented Sep 3, 2020

zbraniecki commented Sep 3, 2020

echeran commented Sep 3, 2020

jira-pull-request-webhook bot commented Sep 17, 2020

zbraniecki commented Sep 17, 2020

jira-pull-request-webhook bot commented Sep 19, 2020

zbraniecki commented Sep 19, 2020

jira-pull-request-webhook bot commented Sep 19, 2020

jira-pull-request-webhook bot commented Oct 7, 2020

jira-pull-request-webhook bot commented Oct 8, 2020

sffc Oct 8, 2020

Add icu-locale macros #220

Add icu-locale macros #220

Conversation

zbraniecki commented Sep 3, 2020

jira-pull-request-webhook bot commented Sep 3, 2020

jira-pull-request-webhook bot commented Sep 3, 2020

jira-pull-request-webhook bot commented Sep 3, 2020

jira-pull-request-webhook bot commented Sep 3, 2020

zbraniecki commented Sep 3, 2020

echeran commented Sep 3, 2020

jira-pull-request-webhook bot commented Sep 17, 2020

zbraniecki commented Sep 17, 2020

jira-pull-request-webhook bot commented Sep 19, 2020

zbraniecki commented Sep 19, 2020

jira-pull-request-webhook bot commented Sep 19, 2020

jira-pull-request-webhook bot commented Oct 7, 2020

jira-pull-request-webhook bot commented Oct 8, 2020

sffc Oct 8, 2020

Choose a reason for hiding this comment