Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The OrigL scripture pane moved to 3rd default scripture pane #173

Merged
merged 10 commits into from
Aug 28, 2023
Merged

The OrigL scripture pane moved to 3rd default scripture pane #173

merged 10 commits into from
Aug 28, 2023

Conversation

Joel-C-Johnson
Copy link
Collaborator

@Joel-C-Johnson Joel-C-Johnson commented Aug 1, 2023 •
edited
Loading

Describe what your pull request addresses

  • Move Original Language (Greek, Hebrew) text pane to the third position in the scripture pane

Test Instructions

  • login into the app
  • select org "UW" and resource "tN"
  • select any book
  • check the orig language moved to 3rd position

Connected issue

Joel-C-Johnson
Joel-C-Johnson commented Aug 28, 2023
View reviewed changes
Copy link
Collaborator Author

@Joel-C-Johnson Joel-C-Johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the latest changes

jincypjose
jincypjose approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jincypjose jincypjose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jincypjose jincypjose merged commit 3de3ca6 into master Aug 28, 2023
@Joel-C-Johnson
Copy link
Collaborator Author

For testing:

https://deploy-preview-173--scripture-resources-rcl.netlify.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jincypjose jincypjose jincypjose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joel-C-Johnson @jincypjose