Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Original Language (Greek, Hebrew) text pane to the third position in the scripture pane. #1600

Open
birchamp opened this issue Jul 21, 2023 · 6 comments
Assignees
Labels
QA/Passed QA Completed

Comments

@birchamp
Copy link
Contributor

birchamp commented Jul 21, 2023

Users commonly have to copy from the Original scripture pain. Therefore, they want to have that pain closest to the editing fields.

Given: that the user is editing records in a TSV that is scripture based and the Original (Greek/Hebrew) text is displayed.
When: the user opens the TSV file
Then: the default scripture display should show the Original text as the third (rightmost) scripture text.

DoD:

The OrigL scripture pane should be the 3rd default scripture pane

Details:

OrigL pane.png

@birchamp birchamp changed the title Move original text pane to the third position in the scripture pane. Move Original text pane to the third position in the scripture pane. Jul 21, 2023
@birchamp birchamp changed the title Move Original text pane to the third position in the scripture pane. Move Original Language (Greek, Hebrew) text pane to the third position in the scripture pane. Jul 24, 2023
@Joel-C-Johnson
Copy link
Collaborator

Joel-C-Johnson commented Aug 28, 2023

When a position is set to "1" - Greek / Hebrew will be in the first position

image

@Joel-C-Johnson
Copy link
Collaborator

when the position is set to 2 or 3 the original (Greek / Hebrew) will change the column. Default zero is set to the last position.

image

@Joel-C-Johnson
Copy link
Collaborator

@danielklapp
Copy link

Looks good to me. See the original language resource showing in the third position in the scripture pane. Tested with translationCore Create - v1.14 build 266-2dce737.

Screenshot 2023-08-29 at 12 45 34 PM

@elsylambert
Copy link
Contributor

Verified in translationCore Create - v1.14 build 266-2dce737. Original Language is moved to third position in the scripture pane and highlighting is fine. However, I found that the highlight was breaking for multiple occurrences when occurrence was changed, written separately in #1613 in QA fail

@elsylambert elsylambert added the QA/Passed QA Completed label Sep 7, 2023
@Joel-C-Johnson
Copy link
Collaborator

Verified in translationCore Create - v1.14 build 266-2dce737. Original Language is moved to third position in the scripture pane and highlighting is fine. However, I found that the highlight was breaking for multiple occurrences when occurrence was changed, written separately in #1613 in QA fail

For Reference : #1613 (comment)

This was referenced Oct 11, 2023
@elsylambert elsylambert reopened this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA/Passed QA Completed
Projects
None yet
Development

No branches or pull requests

4 participants