Added animation effects for fade and slide #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey UC!
I started using your handy module today for a project and I felt inspired to add some animation effects. These are just regular old-fashioned jQuery animations, nothing special. I've added a method to
DisplayLogicCriteria
calleduseAnimation()
. It works like so:The default animation method is
toggle
ifuseAnimation
is not called (i.e. the default display logic behaviour). My JavaScript is not the best so hopefully you can review that and see if I've done anything silly, though it seems to work. 😜I hope the PR can be of some benefit! 😃
Cheers,
Colin.