Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisplayLogic animation #797

Closed
digitall-it opened this issue Aug 3, 2018 · 5 comments
Closed

DisplayLogic animation #797

digitall-it opened this issue Aug 3, 2018 · 5 comments

Comments

@digitall-it
Copy link
Contributor

Tested on branch for SS3.x. Display Logic on frontend forms do not seem to respect animation config settings in display logic, they always toggle, never fade or slide.

@robbieaverill
Copy link
Contributor

Could we please have steps to reproduce?

@digitall-it
Copy link
Contributor Author

@robbieaverill thank you for answering my question so quick.

Steps to reproduce

  1. Install Silverstripe 3.x
  2. Install Silverstripe-UserForms
  3. Create an UserForm page with display logic criteria
  4. Navigate to the frontend page where the UserForm should appear
  5. Interact with the form fields
  6. The fields appear and disappear abruptly without any fluid animation
  7. Add a new YAML directive
DisplayLogicCriteria:
  default_animation: slide

as per Display Logic issue #68 to force the animation
8. Flush and repeat steps 4-6

Expected result

Animation changes to one of the other supported ones, fadeor slide, much more pleasant on the eyes and showing better which fields have changed, as the UserForm built display logic picks up the directive.

Obtained result

Directive is not followed, behavior remains the same

@robbieaverill
Copy link
Contributor

@digitall-it forgive me if I'm wrong, but this sounds like an issue for the display logic module rather than userforms?

@digitall-it
Copy link
Contributor Author

Display Logic obeys the directive when used without UserForms. Maybe UserForms forces an animation type, I’ll do a check on the rule builder.

@robbieaverill
Copy link
Contributor

Thanks. This sounds to me like an issue that should be raised on that module rather than this. Feel free to reopen the issue if you disagree =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants