Skip to content
This repository has been archived by the owner on Dec 13, 2021. It is now read-only.

fixed localization of doctype naming in overlay content type selector #41

Merged
merged 2 commits into from
Nov 16, 2018

Conversation

frederikreher
Copy link

Previously document type names weren't translated as the doctype names were just returned directly from the InnerContentApiController.
I've implemented a basecontroller with a translation method to make sure the naming is correct.

@leekelleher
Copy link
Contributor

Hi @frederikreher, thanks for the PR! (I've been on vacation, hence the delay in my reply).

I'm happy with the doctype name localization being fixed, but I'm not sure why it needs to be in a base class? If you could add the TranslateItem to the InnerContentApiController itself (and make it private/internal), then that'd be great. We could merge it in. Thanks! 😃

@frederikreher
Copy link
Author

@leekelleher

I'm not sure what is was thinking at that point, maybe just blindly copying the implementation from core. :-) I've moved the method into the InnerContentApiController now - not sure if you'd like the properties above the methods?

@leekelleher
Copy link
Contributor

Cool, thanks @frederikreher, it's very much appreciated. Merging in now.

@leekelleher leekelleher merged commit 413c060 into umco:develop Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants