Localized naming of doctypes is not working in nested content doctype selector overlay

[frederikreher]

A doctype name prefixed with # should be translated using the corresponding dictionary item. This is also the case in general, except in the nested content overlay.

The error seems to be in this specific file: https://github.com/umbraco/Umbraco-CMS/blob/1bb593d264a085f94a3ce3bd710392b350561430/src/Umbraco.Web/PropertyEditors/NestedContentController.cs

In line 20 the name of the doctype is returned directly instead of attempting to translate. The NestedController should translate the names, similarly to the way the ContentTypeController (e.g. line 360) translates them.

[frederikreher]

I've submitted a pull request for the same issue on the inner-content repo. The approach to fix this in core should be similar.

[nul800sebastiaan]

Thanks @frederikreher - I see you've introduced a new method there but I'm sure there's already methods in Umbraco for that somewhere, other things do this translation already. So if you can find those (sorry, I have no pointers at the moment) then we'd love to see a PR for this as well! 👍

[kjac]

@frederikreher I can fix this in the core if you're not up for it yourself.

[kjac]

I'll give this a go 😄

[kjac]

PR in #3696

[frederikreher]

@nul800sebastiaan Would it make sense to remove the internal keyword from the method @kjac used to fix the issue in his pull request?

[nul800sebastiaan]

@frederikreher What is the issue and why do we need to change the visibility of a method?

[frederikreher]

@nul800sebastiaan Since its a method that libraries like inner-content could benefit from i think it would make sense to increase the visibility of the method. As now each plugin requiring doctype translation, should implement a similar method themselves.