[Issue 5277-145] accessibility - Language drop downs do not advise as drop… #9265
Conversation
… downs - screen readers
justinsane98
changed the title
There was a problem hiding this comment.
Hi @justinsane98 given the button is hidden by the ng-if directive when there are no variants (or there are variants and hideChangeVariant is not true), could we set aria-haspopup to true and avoid the additional property binding? Doesn't hurt to be explicit when we can.
…o true instead of binding to the property.
|
Hi there @justinsane98, First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! As a new choice this year, you can opt-out of receiving anything and ask us to improve the planet instead by planting a tree on your behalf. 🌳 Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before February 26, 2021. Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before April, so please bear with us and be patient 🙏 The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |
|
Hi again @justinsane98! We're wrapping up the Hacktoberfest rewards list and haven't heard from you yet, make sure to fill in the form at https://docs.google.com/forms/d/e/1FAIpQLSdvfuqHFn7ib_xxMbVZ3nuyUgUTUCGPwmw0y83kiY4lP3OzKQ/viewform or if you want us to plant a tree on your behalf then you can reply as well and we'll take care of it. Thanks! 👍 |
From the main accessibility task 5277:
#5277
subtask 145:
Language drop downs do not advise as drop downs - screen readers