Skip to content

Commit

Permalink
[Issue 5277-145] accessibility - Language drop downs do not advise as…
Browse files Browse the repository at this point in the history
… drop… (#9265)

* [Issue 5277-145] resolved - Language drop downs do not advise as drop downs - screen readers

* reseolve code change request by @nathanwoulfe and set aria-jaspopup to true instead of binding to the property.

Co-authored-by: Justin Shearer <[email protected]>
  • Loading branch information
justinsane98 and Justin Shearer authored Oct 28, 2020
1 parent 375817d commit e9e8a03
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
maxlength="255" />
</ng-form>

<button type="button" ng-if="vm.hasVariants === true && hideChangeVariant !== true" class="umb-variant-switcher__toggle umb-outline" ng-click="vm.dropdownOpen = !vm.dropdownOpen" ng-class="{'--error': vm.errorsOnOtherVariants}">
<button type="button" ng-if="vm.hasVariants === true && hideChangeVariant !== true" class="umb-variant-switcher__toggle umb-outline" ng-click="vm.dropdownOpen = !vm.dropdownOpen" ng-class="{'--error': vm.errorsOnOtherVariants}" aria-haspopup="true" aria-expanded="{{vm.dropdownOpen}}">
<span ng-bind="editor.content.displayName"></span>
<umb-icon icon="{{vm.dropdownOpen ? 'icon-navigation-up' : 'icon-navigation-down'}}" class="umb-variant-switcher__expand" ng-class="{'icon-navigation-down': !vm.dropdownOpen, 'icon-navigation-up': vm.dropdownOpen}">&nbsp;</umb-icon>
</button>
Expand Down

0 comments on commit e9e8a03

Please sign in to comment.