Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextDialog: Accessibility improvements #9045

Merged
merged 2 commits into from
Nov 22, 2020
Merged

ContextDialog: Accessibility improvements #9045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aa5ae9
Add role and aria attributes as well as a screen reader only description
BatJan Oct 2, 2020
d9b3a97
Add translations to language files
BatJan Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Umbraco.Web.UI.Client/src/views/components/tree/umbcontextdialog/umb-context-dialog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
<div id="dialog" class="umb-modalcolumn fill shadow" on-outside-click="outSideClick()">
<div id="dialog"
class="umb-modalcolumn fill shadow"
on-outside-click="outSideClick()"
role="dialog"
aria-labelledby="contextdialog-title"
aria-describedby="contextdialog-description">
<div class="umb-modalcolumn-header">
<h1>{{dialogTitle}}</h1>
<h1 id="contextdialog-title">{{dialogTitle}}</h1>
<p id="contextdialog-description" class="sr-only">
<localize key="visuallyHiddenTexts_contextDialogDescription" tokens="[dialogTitle,currentNode.name]">Perform action {{dialogTitle}} on the {{currentNode.name}} node</localize>
</p>
</div>
<div class="umb-modalcolumn-body" ng-include="view"></div>
</div>
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2278,6 +2278,7 @@ To manage your website, simply open the Umbraco back office and start adding con
<key alias="hasTranslation">Has translation</key>
<key alias="noTranslation">Missing translation</key>
<key alias="dictionaryListCaption">Dictionary items</key>
<key alias="contextDialogDescription">Perform action %0% on the %1% node</key>
</area>
<area alias="references">
<key alias="tabName">References</key>
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2300,6 +2300,7 @@ To manage your website, simply open the Umbraco back office and start adding con
<key alias="hasTranslation">Has translation</key>
<key alias="noTranslation">Missing translation</key>
<key alias="dictionaryListCaption">Dictionary items</key>
<key alias="contextDialogDescription">Perform action %0% on the %1% node</key>
</area>
<area alias="references">
<key alias="tabName">References</key>
Expand Down