ContextDialog: Accessibility improvements #9045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwoulfe
approved these changes
Nov 22, 2020
nul800sebastiaan
added
hacktoberfest/contrib-2020
and removed
hacktoberfest-accepted
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I have improved the accessibility of the context dialog overlay adding
role="dialog, ´aria-labelledby´,aria-describedbyand a description text + of course added keys in the languages files forenanden_us.I would have loved to add the focus lock as well but in it's current state it's not quite ready yet - I will give it a try again once I've finished the #8522, which contain some changes that takes view changes into account. View changes are exactly the issue here - The current focus lock is not aware if something change state and becomes visible. But once it's fixed I'll give this another shot :-)