Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8.7RC Block list adjustments #8763

Merged

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Aug 30, 2020

Prerequisites

  • I have added steps to test this contribution in the description below

Description

While working on a solution for #8689 I noticed various issues, which I have fixed in this PR.

  • Accessibility enhancements.
  • Added rel="noopener" for security reasons.
  • Stored path views/propertyeditors/blocklist/blocklistentryeditors/ in a variable.
  • Added properties to vm.labels after localization.
  • The add/plus button didn't had same width and height. Furthermore it looked like you never hit the button because it is moving when the cursor position change. Instead this is updated in transform property where it is vertically centered and moved 80% to the left, so the cursor doesn't cover the icon, but it still feels like you hit the button.

2020-08-30_21-24-26

@bjarnef
Copy link
Contributor Author

bjarnef commented Aug 30, 2020

@nielslyngsoe this seems to be a bit nicer. Futhermore maybe umb-code-snippet component could be used in the unsupportedblock editor?
https://github.com/umbraco/Umbraco-CMS/blob/v8/8.7/src/Umbraco.Web.UI.Client/src/views/propertyeditors/blocklist/blocklistentryeditors/unsupportedblock/unsupportedblock.editor.html#L11

E.g. like this change for v8.8?
#8548

@bjarnef bjarnef changed the title V8.7-RC Block list adjustments V8.7RC Block list adjustments Aug 30, 2020
@nul800sebastiaan nul800sebastiaan merged commit 031769f into umbraco:v8/8.7 Aug 31, 2020
@nul800sebastiaan
Copy link
Member

Wonderful updates @bjarnef - thanks very much! 👍

@nul800sebastiaan nul800sebastiaan added category/accessibility category/ux User experience release/8.7.0 release/no-notes This is too small to add to the release notes or fixed after a beta/RC type/feature community/pr labels Aug 31, 2020
@bjarnef bjarnef deleted the v8/feature/block-list-label-template branch August 31, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/accessibility category/ux User experience community/pr release/no-notes This is too small to add to the release notes or fixed after a beta/RC release/8.7.0 type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants