Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid cell error could use "umb-code-snippet" directive? #8548

Conversation

leekelleher
Copy link
Member

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Thanks to @bjarnef's excellent umb-code-snippet component #7294, it could be used when displaying errors with Grid editors cells?

Currently the error.html#L2 is using a <pre>, where as with <umb-code-snippet> it would also offer the Copy button - useful for sharing/debugging purposes.

with <pre>
1

with <umb-code-snippet>
2

A small incremental improvement.

@nul800sebastiaan
Copy link
Member

Thanks @leekelleher! Lovely with the copy button indeed, makes total sense to me, thanks! 👍

@nul800sebastiaan nul800sebastiaan merged commit 9ceecb2 into umbraco:v8/contrib Aug 24, 2020
@leekelleher leekelleher deleted the v8/patch/grid-error-code-snippet branch August 24, 2020 15:22
@leekelleher
Copy link
Member Author

Cool, thanks @nul800sebastiaan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants