Add utility function equivalent to angular.fromJson

[bjarnef]

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

This previous PR #7952 replacing angular.fromJson from JSON.parse seems to fail as angular.fromJson also checked in the value passed in was equal to an string value.
https://github.com/angular/angular.js/blob/master/src/Angular.js#L1335-L1339

E.g. when inserting an image editor in grid content it is causing an console error, when session storage is empty.

Furthermore we now have a Utilities.toJson() function #7924 so I think we should have an Utilities.fromJson as well.

You can of course always use the traditional JSON.parse inside a try/catch block in e.g, but this method (similar to the angular.fromJson() only try to parse the value if it is an string value).

try {
    var obj = JSON.parse(value);
}
catch { 

}

[bjarnef]

Before

After

I do however get an YSOD when saving an content with empty image grid editor (or an selected image), but I think this is another underlying issue.

[bjarnef]

@nul800sebastiaan it seems there have been some other underlying issues regarding when having an image grid editor in grid and saving the content, but we can look at this in another PR.

[lars-erik]

I just hit the same issue and was about to fix that as well. Will merge this to test mine. When cropping, you hit another issue. See #8013. I wanna see about using the cropper from the imagecropper datatype instead as well, maybe in another PR tho.

[bjarnef]

The YSOD I get when saving grid content with image grid editor (or just a regular property using media picker) seems to be because I am missing some relations, e.g. umbMedia.
193892f

Maybe the upgrader didn't run as expected after I previous pulled some of the latest changes in v8/contrib branch.

[bjarnef]

I installed in clean Umbraco install and installed the starter kit. I now have the "Related Media" and "Related Content" relations. However I think these shouldn't have the "delete" actions since it would break stuff if these are deleted. Maybe these should be "locked" similar to default listview datatypes used in content, media and member?

I think bad things could happen, if these are deleted. I have reported a feature request for this here: #8021

[nielslyngsoe]

This addition to Utilities is great! Thanks

[bjarnef]

@nielslyngsoe shouldn't this be merged into v8/contrib which is this default branch now?

[nielslyngsoe]

@nielslyngsoe shouldn't this be merged into v8/contrib which is this default branch now?

Yes and no — Normally I wouldn't be merging these PRs. But we needed it straight away so I just decided to merge it directly to the dev branch. The Dev branch should be merged back to contrib branch each day so hopefully, no one was waiting on this one. Hence no one did merge it from the contrib-team.

[bjarnef]

@nielslyngsoe yeah, I just needed this fix when submitting other PRs, but I had the change locally and only comitted the relevant changes for the specific feature/bug. It seems this is merged to v8/contrib now, so that's great 👍